Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/openstack: Allow numerical protocols in security group rules #14917

Merged
merged 1 commit into from
May 30, 2017
Merged

provider/openstack: Allow numerical protocols in security group rules #14917

merged 1 commit into from
May 30, 2017

Conversation

jtopjian
Copy link
Contributor

This commit enables a user to specify protocols in numerical form
when creating security group rules.

Based on the comment here: #14307 (comment)

cc @jaydub

@jtopjian
provider/openstack: Allow numerical protocols in security group rules
d311417 
This commit enables a user to specify protocols in numerical form
when creating security group rules.
@jtopjian
Copy link
Contributor Author 

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/29 22:09:56 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/openstack -v -run=TestAccNetworkingV2SecGroupRule -timeout 120m
=== RUN   TestAccNetworkingV2SecGroupRule_importBasic
--- PASS: TestAccNetworkingV2SecGroupRule_importBasic (29.60s)
=== RUN   TestAccNetworkingV2SecGroupRule_basic
--- PASS: TestAccNetworkingV2SecGroupRule_basic (27.52s)
=== RUN   TestAccNetworkingV2SecGroupRule_lowerCaseCIDR
--- PASS: TestAccNetworkingV2SecGroupRule_lowerCaseCIDR (26.05s)
=== RUN   TestAccNetworkingV2SecGroupRule_timeout
--- PASS: TestAccNetworkingV2SecGroupRule_timeout (26.45s)
=== RUN   TestAccNetworkingV2SecGroupRule_protocols
--- PASS: TestAccNetworkingV2SecGroupRule_protocols (53.28s)
=== RUN   TestAccNetworkingV2SecGroupRule_numericProtocol
--- PASS: TestAccNetworkingV2SecGroupRule_numericProtocol (25.06s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/openstack      187.975s

@stack72
Copy link
Contributor

stack72 commented May 30, 2017

LGTM! Merge at will :)

@jtopjian jtopjian merged commit ff1c2b1 into hashicorp:master May 30, 2017
@jtopjian
Copy link
Contributor Author

Thanks, Paul!

@jtopjian jtopjian mentioned this pull request Jun 1, 2017
Closed
@jaydub
Copy link

jaydub commented Jun 7, 2017

I look away for a week, and you solve the problem :-D Bravo!

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtopjian @stack72 @jaydub